From cefca7e8c5b1e56c24f6082d3245907b0346af1c Mon Sep 17 00:00:00 2001
From: aurelien <aurelien.plancke.etu@univ-lille.fr>
Date: Fri, 25 Jun 2021 11:14:06 +0200
Subject: [PATCH] =?UTF-8?q?Ajout=20d'id=20et=20de=20classes=20permettant?=
 =?UTF-8?q?=20aux=20tests=20S=C3=A9l=C3=A9nium=20de=20se=20r=C3=A9p=C3=A8r?=
 =?UTF-8?q?er=20par=20rapport=20au=20DOM?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 app/scodoc/TrivialFormulator.py             |  2 +-
 app/scodoc/ZScoUsers.py                     |  2 +-
 app/scodoc/html_sidebar.py                  | 24 +++++++++++----------
 app/scodoc/sco_dept.py                      |  2 +-
 app/scodoc/sco_etud.py                      |  8 +++++--
 app/scodoc/sco_find_etud.py                 |  2 +-
 app/scodoc/sco_formations.py                | 12 +++++------
 app/scodoc/sco_formsemestre_inscriptions.py |  9 ++++++--
 app/scodoc/sco_formsemestre_validation.py   | 13 +++++++----
 app/scodoc/sco_moduleimpl_status.py         | 11 ++++++++--
 app/scodoc/sco_page_etud.py                 |  6 +++---
 app/views/notes.py                          |  2 +-
 12 files changed, 58 insertions(+), 35 deletions(-)

diff --git a/app/scodoc/TrivialFormulator.py b/app/scodoc/TrivialFormulator.py
index dd279afa..881c0e08 100644
--- a/app/scodoc/TrivialFormulator.py
+++ b/app/scodoc/TrivialFormulator.py
@@ -760,6 +760,6 @@ def tf_error_message(msg):
     if type(msg) == StringType:
         msg = [msg]
     return (
-        '<ul class="tf-msg"><li class="tf-msg">%s</li></ul>'
+        '<ul class="tf-msg"><li id="error-message" class="tf-msg">%s</li></ul>'
         % '</li><li class="tf-msg">'.join(msg)
     )
diff --git a/app/scodoc/ZScoUsers.py b/app/scodoc/ZScoUsers.py
index a8418ed4..046c3ecc 100644
--- a/app/scodoc/ZScoUsers.py
+++ b/app/scodoc/ZScoUsers.py
@@ -135,7 +135,7 @@ class ZScoUsers(
 
         if authuser.has_permission(Permission.ScoUsersAdmin, self):
             H.append(
-                '<p><a href="create_user_form" class="stdlink">Ajouter un utilisateur</a>'
+                '<p><a id="create-user" href="create_user_form" class="stdlink">Ajouter un utilisateur</a>'
             )
             H.append(
                 '&nbsp;&nbsp; <a href="import_users_form" class="stdlink">Importer des utilisateurs</a></p>'
diff --git a/app/scodoc/html_sidebar.py b/app/scodoc/html_sidebar.py
index 4083a75d..28ec7419 100644
--- a/app/scodoc/html_sidebar.py
+++ b/app/scodoc/html_sidebar.py
@@ -50,9 +50,9 @@ def sidebar_common(context, REQUEST=None):
         % params,
         sidebar_dept(context, REQUEST),
         """<h2 class="insidebar">Scolarit&eacute;</h2>
- <a href="%(ScoURL)s" class="sidebar">Semestres</a> <br/> 
- <a href="%(NotesURL)s" class="sidebar">Programmes</a> <br/> 
- <a href="%(AbsencesURL)s" class="sidebar">Absences</a> <br/>
+ <a id="link-semestre" href="%(ScoURL)s" class="sidebar">Semestres</a> <br/> 
+ <a id="link-programmes" href="%(NotesURL)s" class="sidebar">Programmes</a> <br/> 
+ <a id="link-absence" href="%(AbsencesURL)s" class="sidebar">Absences</a> <br/>
  """
         % params,
     ]
@@ -61,12 +61,13 @@ def sidebar_common(context, REQUEST=None):
         Permission.ScoUsersView
     ):
         H.append(
-            """<a href="%(UsersURL)s" class="sidebar">Utilisateurs</a> <br/>""" % params
+            """<a id="link-view-users" href="%(UsersURL)s" class="sidebar">Utilisateurs</a> <br/>"""
+            % params
         )
 
     if authuser.has_permission(Permission.ScoChangePreferences):
         H.append(
-            """<a href="%(ScoURL)s/edit_preferences" class="sidebar">Paramétrage</a> <br/>"""
+            """<a id="link-preferences" href="%(ScoURL)s/edit_preferences" class="sidebar">Paramétrage</a> <br/>"""
             % params
         )
 
@@ -102,6 +103,7 @@ def sidebar(context, REQUEST=None):
             """<h2 id="insidebar-etud"><a href="%(ScoURL)s/ficheEtud?etudid=%(etudid)s" class="sidebar">
     <font color="#FF0000">%(civilite_str)s %(nom_disp)s</font></a>
     </h2>
+    <p id="euid">%(etudid)s</p>
     <b>Absences</b>"""
             % params
         )
@@ -121,21 +123,21 @@ def sidebar(context, REQUEST=None):
         if REQUEST.AUTHENTICATED_USER.has_permission(Permission.ScoAbsChange):
             H.append(
                 """
-<li>     <a href="%(ScoURL)s/Absences/SignaleAbsenceEtud?etudid=%(etudid)s">Ajouter</a></li>
-<li>     <a href="%(ScoURL)s/Absences/JustifAbsenceEtud?etudid=%(etudid)s">Justifier</a></li>
-<li>     <a href="%(ScoURL)s/Absences/AnnuleAbsenceEtud?etudid=%(etudid)s">Supprimer</a></li>
+<li>     <a id="add-absence" href="%(ScoURL)s/Absences/SignaleAbsenceEtud?etudid=%(etudid)s">Ajouter</a></li>
+<li>     <a id="justify-absence" href="%(ScoURL)s/Absences/JustifAbsenceEtud?etudid=%(etudid)s">Justifier</a></li>
+<li>     <a id="delete-absence" href="%(ScoURL)s/Absences/AnnuleAbsenceEtud?etudid=%(etudid)s">Supprimer</a></li>
 """
                 % params
             )
             if sco_preferences.get_preference(context, "handle_billets_abs"):
                 H.append(
-                    """<li>     <a href="%(ScoURL)s/Absences/listeBilletsEtud?etudid=%(etudid)s">Billets</a></li>"""
+                    """<li>     <a id="display-billet" href="%(ScoURL)s/Absences/listeBilletsEtud?etudid=%(etudid)s">Billets</a></li>"""
                     % params
                 )
         H.append(
             """
-<li>     <a href="%(ScoURL)s/Absences/CalAbs?etudid=%(etudid)s">Calendrier</a></li>
-<li>     <a href="%(ScoURL)s/Absences/ListeAbsEtud?etudid=%(etudid)s">Liste</a></li>
+<li>     <a id="display-calendar" href="%(ScoURL)s/Absences/CalAbs?etudid=%(etudid)s">Calendrier</a></li>
+<li>     <a id="display-list-absence" href="%(ScoURL)s/Absences/ListeAbsEtud?etudid=%(etudid)s">Liste</a></li>
 </ul>
 """
             % params
diff --git a/app/scodoc/sco_dept.py b/app/scodoc/sco_dept.py
index 8461b890..5df1eec8 100644
--- a/app/scodoc/sco_dept.py
+++ b/app/scodoc/sco_dept.py
@@ -146,7 +146,7 @@ Chercher étape courante: <input name="etape_apo" type="text" size="8" spellchec
             """<hr>
         <h3>Gestion des étudiants</h3>
         <ul>
-        <li><a class="stdlink" href="etudident_create_form">créer <em>un</em> nouvel étudiant</a></li>
+        <li><a class="stdlink" id="link-create-student" href="etudident_create_form">créer <em>un</em> nouvel étudiant</a></li>
         <li><a class="stdlink" href="form_students_import_excel">importer de nouveaux étudiants</a> (ne pas utiliser sauf cas particulier, utilisez plutôt le lien dans
         le tableau de bord semestre si vous souhaitez inscrire les
         étudiants importés à un semestre)</li>
diff --git a/app/scodoc/sco_etud.py b/app/scodoc/sco_etud.py
index 931c3fc3..35fddeed 100644
--- a/app/scodoc/sco_etud.py
+++ b/app/scodoc/sco_etud.py
@@ -351,7 +351,8 @@ def _check_duplicate_code(cnx, args, code_name, context, edit=True, REQUEST=None
             if context:
                 err_page = scu.confirm_dialog(
                     context,
-                    message="""<h3>Code étudiant (%s) dupliqué !</h3>""" % code_name,
+                    message="""<h3 class="title-error">Code étudiant (%s) dupliqué !</h3>"""
+                    % code_name,
                     helpmsg="""Le %s %s est déjà utilisé: un seul étudiant peut avoir ce code. Vérifier votre valeur ou supprimer l'autre étudiant avec cette valeur.<p><ul><li>"""
                     % (code_name, args[code_name])
                     + "</li><li>".join(listh)
@@ -362,7 +363,10 @@ def _check_duplicate_code(cnx, args, code_name, context, edit=True, REQUEST=None
                     REQUEST=REQUEST,
                 )
             else:
-                err_page = """<h3>Code étudiant (%s) dupliqué !</h3>""" % code_name
+                err_page = (
+                    """<h3 class="title-error">Code étudiant (%s) dupliqué !</h3>"""
+                    % code_name
+                )
             log("*** error: code %s duplique: %s" % (code_name, args[code_name]))
             raise ScoGenError(err_page)
 
diff --git a/app/scodoc/sco_find_etud.py b/app/scodoc/sco_find_etud.py
index 2ac608a3..ace269b6 100644
--- a/app/scodoc/sco_find_etud.py
+++ b/app/scodoc/sco_find_etud.py
@@ -55,7 +55,7 @@ def form_search_etud(
     H.append(
         """<form action="search_etud_in_dept" method="POST">
     <b>%s</b>
-    <input type="text" name="expnom" width="12" spellcheck="false" value="">
+    <input type="text" id="search-student" name="expnom" width="12" spellcheck="false" value="">
     <input type="submit" value="Chercher">
     <br/>(entrer une partie du nom)
     """
diff --git a/app/scodoc/sco_formations.py b/app/scodoc/sco_formations.py
index e4ac0acb..ec7b2010 100644
--- a/app/scodoc/sco_formations.py
+++ b/app/scodoc/sco_formations.py
@@ -287,8 +287,8 @@ def formation_list_table(context, formation_id=None, args={}, REQUEST=None):
                 for s in f["sems"]
             ]
             + [
-                '<a class="stdlink" href="formsemestre_createwithmodules?formation_id=%(formation_id)s&semestre_id=1">ajouter</a>'
-                % f
+                '<a id="add-semestre-%s" class="stdlink" href="formsemestre_createwithmodules?formation_id=%(formation_id)s&semestre_id=1">ajouter</a>'
+                % (f["acronyme"].lower().replace(" ","-"), f["formation_id"])
             ]
         )
         if f["sems"]:
@@ -305,15 +305,15 @@ def formation_list_table(context, formation_id=None, args={}, REQUEST=None):
             but_locked = '<span class="but_placeholder"></span>'
         if editable and not locked:
             but_suppr = (
-                '<a class="stdlink" href="formation_delete?formation_id=%s">%s</a>'
-                % (f["formation_id"], suppricon)
+                '<a id="delete-formation-%s" class="stdlink" href="formation_delete?formation_id=%s">%s</a>'
+                % (f["acronyme"].lower().replace(" ", "-"), f["formation_id"], suppricon)
             )
         else:
             but_suppr = '<span class="but_placeholder"></span>'
         if editable:
             but_edit = (
-                '<a class="stdlink" href="formation_edit?formation_id=%s">%s</a>'
-                % (f["formation_id"], editicon)
+                '<a id="edit-formation-%s" class="stdlink" href="formation_edit?formation_id=%s">%s</a>'
+                % (f["acronyme"].lower().replace(" ","-"), f["formation_id"], editicon)
             )
         else:
             but_edit = '<span class="but_placeholder"></span>'
diff --git a/app/scodoc/sco_formsemestre_inscriptions.py b/app/scodoc/sco_formsemestre_inscriptions.py
index 1b007aac..5b847140 100644
--- a/app/scodoc/sco_formsemestre_inscriptions.py
+++ b/app/scodoc/sco_formsemestre_inscriptions.py
@@ -307,9 +307,14 @@ def formsemestre_inscription_with_modules_form(
                 if (not only_ext) or (sem["modalite"] == "EXT"):
                     H.append(
                         """
-                    <li><a class="stdlink" href="formsemestre_inscription_with_modules?etudid=%s&formsemestre_id=%s">%s</a>
+                    <li><a id="inscription-semestre-%s" class="stdlink" href="formsemestre_inscription_with_modules?etudid=%s&formsemestre_id=%s">%s</a>
                     """
-                        % (etudid, sem["formsemestre_id"], sem["titremois"])
+                        % (
+                            sem["formsemetre_id"].lower().replace(" ","-"),
+                            etudid,
+                            sem["formsemestre_id"],
+                            sem["titremois"],
+                        )
                     )
         H.append("</ul>")
     else:
diff --git a/app/scodoc/sco_formsemestre_validation.py b/app/scodoc/sco_formsemestre_validation.py
index 072c15b8..baade7d0 100644
--- a/app/scodoc/sco_formsemestre_validation.py
+++ b/app/scodoc/sco_formsemestre_validation.py
@@ -461,8 +461,8 @@ def decisions_possible_rows(Se, assiduite, subtitle="", trclass=""):
     H.append("<th>Code %s</th><th>Devenir</th></tr>" % TitleCur)
     for ch in choices:
         H.append(
-            """<tr class="%s"><td title="règle %s"><input type="radio" name="codechoice" value="%s" onClick="document.getElementById('subut').disabled=false;">"""
-            % (trclass, ch.rule_id, ch.codechoice)
+            """<tr class="%s"><td title="règle %s"><input type="radio" id="input-choice-%s" name="codechoice" value="%s" onClick="document.getElementById('subut').disabled=false;">"""
+            % (trclass, ch.rule_id, ch.codechoice, ch_rule_id)
         )
         H.append("%s </input></td>" % ch.explication)
         if Se.prev:
@@ -647,8 +647,13 @@ def formsemestre_recap_parcours_table(
                 # log('')
 
             H.append(
-                '<td class="%s" title="%s">%s</td>'
-                % (class_ue, " ".join(explanation_ue), scu.fmt_note(moy_ue))
+                '<td id="ue-%s" class="%s" title="%s">%s</td>'
+                % (
+                    ue["acronyme"].lower().replace(" ","-"),
+                    class_ue,
+                    " ".join(explanation_ue),
+                    scu.fmt_note(moy_ue),
+                )
             )
         if len(ues) < Se.nb_max_ue:
             H.append('<td colspan="%d"></td>' % (Se.nb_max_ue - len(ues)))
diff --git a/app/scodoc/sco_moduleimpl_status.py b/app/scodoc/sco_moduleimpl_status.py
index b9f35586..958826ea 100644
--- a/app/scodoc/sco_moduleimpl_status.py
+++ b/app/scodoc/sco_moduleimpl_status.py
@@ -348,7 +348,7 @@ def moduleimpl_status(context, moduleimpl_id=None, partition_id=None, REQUEST=No
     top_table_links = ""
     if sem["etat"] == "1":  # non verrouillé
         top_table_links = (
-            """<a class="stdlink" href="evaluation_create?moduleimpl_id=%(moduleimpl_id)s">Créer nouvelle évaluation</a>
+            """<a id="link-add-evaluation" class="stdlink" href="evaluation_create?moduleimpl_id=%(moduleimpl_id)s">Créer nouvelle évaluation</a>
         <a class="stdlink" style="margin-left:2em;" href="module_evaluation_renumber?moduleimpl_id=%(moduleimpl_id)s&redirect=1">Trier par date</a>
         """
             % M
@@ -483,7 +483,14 @@ def moduleimpl_status(context, moduleimpl_id=None, partition_id=None, REQUEST=No
                     """<a class="smallbutton" href="evaluation_delete?evaluation_id=%(evaluation_id)s">"""
                     % eval
                 )
-            H.append(scu.icontag("delete_img", alt="supprimer", title="Supprimer"))
+            H.append(
+                scu.icontag(
+                    "delete_img",
+                    alt="supprimer",
+                    title="Supprimer",
+                    id="button-delete-%s" % eval["evaluation_id"],
+                )
+            )
             if caneditevals:
                 H.append("""</a>""")
         elif etat["evalcomplete"]:
diff --git a/app/scodoc/sco_page_etud.py b/app/scodoc/sco_page_etud.py
index 07e11e7f..beb52e3b 100644
--- a/app/scodoc/sco_page_etud.py
+++ b/app/scodoc/sco_page_etud.py
@@ -415,16 +415,16 @@ def ficheEtud(context, etudid=None, REQUEST=None):
 <div class="fichesituation">
 <div class="fichetablesitu">
 <table>
-<tr><td class="fichetitre2">Situation :</td><td>%(situation)s</td></tr>
+<tr><td class="fichetitre2">Situation :</td><td id="student-situation">%(situation)s</td></tr>
 %(groupes_row)s
-<tr><td class="fichetitre2">Né%(ne)s le :</td><td>%(info_naissance)s</td></tr>
+<tr><td class="fichetitre2">Né%(ne)s le :</td><td id="student-birth">%(info_naissance)s</td></tr>
 </table>
 
 
 <!-- Adresse -->
 <div class="ficheadresse" id="ficheadresse">
 <table><tr>
-<td class="fichetitre2">Adresse :</td><td> %(domicile)s %(codepostaldomicile)s %(villedomicile)s %(paysdomicile)s
+<td class="fichetitre2">Adresse :</td><td id="student-address"> %(domicile)s %(codepostaldomicile)s %(villedomicile)s %(paysdomicile)s
 %(modifadresse)s
 %(telephones)s
 </td></tr></table>
diff --git a/app/views/notes.py b/app/views/notes.py
index 07b990d1..5373a9db 100644
--- a/app/views/notes.py
+++ b/app/views/notes.py
@@ -382,7 +382,7 @@ def index_html(context, REQUEST=None):
 
     if editable:
         H.append(
-            """<p><a class="stdlink" href="formation_create">Créer une formation</a></p>
+            """<p><a id="link-create-formation" class="stdlink" href="formation_create">Créer une formation</a></p>
     <p><a class="stdlink" href="formation_import_xml_form">Importer une formation (xml)</a></p>
         <p class="help">Une "formation" est un programme pédagogique structuré en UE, matières et modules. Chaque semestre se réfère à une formation. La modification d'une formation affecte tous les semestres qui s'y réfèrent.</p>
         """