ScoDoc/ScoDoc
ScoDoc
/
ScoDoc
6
2
Fork 15
Code Issues 146 Pull Requests 1 Projects 3 Releases 129 Wiki Activity

Plantage API sur formsemestre inexistant lors de la recherche du bulletin d'un étudiant #470

New Issue
Closed
opened 2022-08-06 10:54:32 +02:00 by jmplace · 1 comment
jmplace commented 2022-08-06 10:54:32 +02:00
Collaborator
Copy Link

Contexte:

  • l'étudiant 12107 existe
  • le formsemestre 944 existe
  • l'étudiant 12107 n'est pas inscrit au 944

la requete:
/api/etudiant/12017/formsmestre/944/bulletin ne retourne pas un 404 mais plante avec la pile d appel suivante:

Traceback (most recent call last):
  File "/opt/scodoc/venv/lib/python3.9/site-packages/pandas/core/indexes/base.py", line 3621, in get_loc
    return self._engine.get_loc(casted_key)
  File "pandas/_libs/index.pyx", line 136, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/index.pyx", line 163, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/hashtable_class_helper.pxi", line 2131, in pandas._libs.hashtable.Int64HashTable.get_item
  File "pandas/_libs/hashtable_class_helper.pxi", line 2140, in pandas._libs.hashtable.Int64HashTable.get_item
KeyError: 12107

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/scodoc/venv/lib/python3.9/site-packages/flask/app.py", line 2095, in __call__
    return self.wsgi_app(environ, start_response)
  File "/opt/scodoc/app/__init__.py", line 212, in __call__
    return self.app(environ, start_response)
  File "/opt/scodoc/venv/lib/python3.9/site-packages/flask/app.py", line 2080, in wsgi_app
    response = self.handle_exception(e)
  File "/opt/scodoc/venv/lib/python3.9/site-packages/flask/app.py", line 2077, in wsgi_app
    response = self.full_dispatch_request()
  File "/opt/scodoc/venv/lib/python3.9/site-packages/flask/app.py", line 1525, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/opt/scodoc/venv/lib/python3.9/site-packages/flask/app.py", line 1523, in full_dispatch_request
    rv = self.dispatch_request()
  File "/opt/scodoc/venv/lib/python3.9/site-packages/flask/app.py", line 1509, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
  File "/opt/scodoc/app/decorators.py", line 79, in scodoc_function
    return func(*args, **kwargs)
  File "/opt/scodoc/app/decorators.py", line 91, in decorated_function
    return f(*args, **kwargs)
  File "/opt/scodoc/app/api/etudiants.py", line 353, in etudiant_bulletin_semestre
    return sco_bulletins.get_formsemestre_bulletin_etud_json(
  File "/opt/scodoc/app/scodoc/sco_bulletins.py", line 79, in get_formsemestre_bulletin_etud_json
    r.bulletin_etud(
  File "/opt/scodoc/app/but/bulletin_but.py", line 281, in bulletin_etud
    etud_ues_ids = res.etud_ues_ids(etud.id)
  File "/opt/scodoc/app/comp/res_but.py", line 235, in etud_ues_ids
    s = self.ues_inscr_parcours_df.loc[etudid]
  File "/opt/scodoc/venv/lib/python3.9/site-packages/pandas/core/indexing.py", line 967, in __getitem__
    return self._getitem_axis(maybe_callable, axis=axis)
  File "/opt/scodoc/venv/lib/python3.9/site-packages/pandas/core/indexing.py", line 1202, in _getitem_axis
    return self._get_label(key, axis=axis)
  File "/opt/scodoc/venv/lib/python3.9/site-packages/pandas/core/indexing.py", line 1153, in _get_label
    return self.obj.xs(label, axis=axis)
  File "/opt/scodoc/venv/lib/python3.9/site-packages/pandas/core/generic.py", line 3864, in xs
    loc = index.get_loc(key)
  File "/opt/scodoc/venv/lib/python3.9/site-packages/pandas/core/indexes/base.py", line 3623, in get_loc
    raise KeyError(key) from err
KeyError: 12107

Proposition:
dans api/etudiants ligne 328-329, on teste bien que le formsemestre existe mais pas que l'étudiant y est effectivement inscrit.

    formsemestre = FormSemestre.query.filter_by(id=formsemestre_id).first_or_404()
    dept = Departement.query.filter_by(id=formsemestre.dept_id).first_or_404()

remarque:
On trouve un comportement similaire (différence de comportement entre un formsemestre inexistant et un formsemestre où l'étudiant ne figure pas) mais pour cette entrée le problème est moins grave (on retourne une liste vide au lieu d'une erreur 404).
si besoin compléter entre les lignes 399 et 399.

	query = FormSemestre.query.filter_by(id=formsemestre_id)
    if g.scodoc_dept:
        query = query.filter_by(dept_id=g.scodoc_dept_id)
Contexte: * l'étudiant 12107 existe * le formsemestre 944 existe * l'étudiant 12107 n'est pas inscrit au 944 la requete: `/api/etudiant/12017/formsmestre/944/bulletin` ne retourne pas un 404 mais plante avec la pile d appel suivante: ``` Traceback (most recent call last): File "/opt/scodoc/venv/lib/python3.9/site-packages/pandas/core/indexes/base.py", line 3621, in get_loc return self._engine.get_loc(casted_key) File "pandas/_libs/index.pyx", line 136, in pandas._libs.index.IndexEngine.get_loc File "pandas/_libs/index.pyx", line 163, in pandas._libs.index.IndexEngine.get_loc File "pandas/_libs/hashtable_class_helper.pxi", line 2131, in pandas._libs.hashtable.Int64HashTable.get_item File "pandas/_libs/hashtable_class_helper.pxi", line 2140, in pandas._libs.hashtable.Int64HashTable.get_item KeyError: 12107 The above exception was the direct cause of the following exception: Traceback (most recent call last): File "/opt/scodoc/venv/lib/python3.9/site-packages/flask/app.py", line 2095, in __call__ return self.wsgi_app(environ, start_response) File "/opt/scodoc/app/__init__.py", line 212, in __call__ return self.app(environ, start_response) File "/opt/scodoc/venv/lib/python3.9/site-packages/flask/app.py", line 2080, in wsgi_app response = self.handle_exception(e) File "/opt/scodoc/venv/lib/python3.9/site-packages/flask/app.py", line 2077, in wsgi_app response = self.full_dispatch_request() File "/opt/scodoc/venv/lib/python3.9/site-packages/flask/app.py", line 1525, in full_dispatch_request rv = self.handle_user_exception(e) File "/opt/scodoc/venv/lib/python3.9/site-packages/flask/app.py", line 1523, in full_dispatch_request rv = self.dispatch_request() File "/opt/scodoc/venv/lib/python3.9/site-packages/flask/app.py", line 1509, in dispatch_request return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args) File "/opt/scodoc/app/decorators.py", line 79, in scodoc_function return func(*args, **kwargs) File "/opt/scodoc/app/decorators.py", line 91, in decorated_function return f(*args, **kwargs) File "/opt/scodoc/app/api/etudiants.py", line 353, in etudiant_bulletin_semestre return sco_bulletins.get_formsemestre_bulletin_etud_json( File "/opt/scodoc/app/scodoc/sco_bulletins.py", line 79, in get_formsemestre_bulletin_etud_json r.bulletin_etud( File "/opt/scodoc/app/but/bulletin_but.py", line 281, in bulletin_etud etud_ues_ids = res.etud_ues_ids(etud.id) File "/opt/scodoc/app/comp/res_but.py", line 235, in etud_ues_ids s = self.ues_inscr_parcours_df.loc[etudid] File "/opt/scodoc/venv/lib/python3.9/site-packages/pandas/core/indexing.py", line 967, in __getitem__ return self._getitem_axis(maybe_callable, axis=axis) File "/opt/scodoc/venv/lib/python3.9/site-packages/pandas/core/indexing.py", line 1202, in _getitem_axis return self._get_label(key, axis=axis) File "/opt/scodoc/venv/lib/python3.9/site-packages/pandas/core/indexing.py", line 1153, in _get_label return self.obj.xs(label, axis=axis) File "/opt/scodoc/venv/lib/python3.9/site-packages/pandas/core/generic.py", line 3864, in xs loc = index.get_loc(key) File "/opt/scodoc/venv/lib/python3.9/site-packages/pandas/core/indexes/base.py", line 3623, in get_loc raise KeyError(key) from err KeyError: 12107 ``` Proposition: dans api/etudiants ligne 328-329, on teste bien que le formsemestre existe mais pas que l'étudiant y est effectivement inscrit. ```python formsemestre = FormSemestre.query.filter_by(id=formsemestre_id).first_or_404() dept = Departement.query.filter_by(id=formsemestre.dept_id).first_or_404() ``` remarque: On trouve un comportement similaire (différence de comportement entre un formsemestre inexistant et un formsemestre où l'étudiant ne figure pas) mais pour cette entrée le problème est moins grave (on retourne une liste vide au lieu d'une erreur 404). si besoin compléter entre les lignes 399 et 399. ```python query = FormSemestre.query.filter_by(id=formsemestre_id) if g.scodoc_dept: query = query.filter_by(dept_id=g.scodoc_dept_id) ```
viennet added the
API
 label 2022-08-07 14:27:59 +02:00
viennet commented 2022-08-08 10:35:08 +02:00
Owner
Copy Link

Fixed by f0c342fad5

Fixed by f0c342fad5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
iziram-main96b
RGPD
edt
assi_ev
prod
revamp-jquery
bul_but
sco96
sco95
jury_but
hotfix_auto
bac_a_sable_prod
table
upgrading_pip
cas
iziram-rev
xp
hotfix
entreprises
orebut
PNBUT
ScoDoc7
ScoDoc8
nosex
9.6.965
9.6.964
9.6.963
9.6.962
9.6.961
9.6.960
9.6.959
9.6.958
9.6.957
9.6.956
9.6.955
9.6.954
9.6.953
9.6.952
9.6.951
9.6.950
9.6.949
9.6.948
9.6.947
9.6.946
9.6.945
9.6.943
9.6.942
9.6.941
9.6.940
9.6.939
9.6.938
9.6.937
9.6.936
9.6.935
9.6.934
9.6.933
9.6.932
9.6.931
9.6.93
9.6.92
9.6.91
9.6.90
9.6.89
9.6.88
9.6.87
9.6.86
9.6.85
9.6.84
9.6.83
9.6.82
9.6.81
9.6.80
9.6.79
9.6.78
9.6.77
9.6.76
9.6.75
9.6.74
9.6.73
9.6.72
9.6.71
9.6.70
9.6.69
9.6.68
9.6.67
9.6.66
9.6.65
9.6.64
9.6.63
9.6.62
9.6.61
9.6.60
9.6.59
9.6.58
9.6.57
9.6.56
9.6.55
9.6.54
9.6.53
9.6.52
9.6.51
9.6.50
9.6.49
9.6.48
9.6.47
9.6.46
9.6.45
9.6.44
9.6.43
9.6.42
9.6.41
9.6.40
9.6.39
9.6.38
9.6.37
9.6.36
9.6.35
9.6.34
9.6.33
9.6.32
9.6.31
9.6.30
9.6.29
9.6.28
9.6.27
9.6.26
9.6.25
9.6.24
9.6.23
9.6.21
9.6.20
9.6.19
9.6.18
9.6.17
9.6.16
9.6.15
9.6.14
9.6.13
9.6.12
9.6.11
9.6.10
9.6.9
9.6.8
9.5.8
9.6.6
9.6.5
9.5.7
9.6.4
9.6.2
9.5.6
9.6.0
9.5.5
9.5.4
9.5.3
9.5.2
9.5.1
9.5.0
9.4.99
9.4.98
9.4.97
9.4.96
9.4.95
9.4.94
9.4.93
9.4.92
9.4.91
9.4.90
9.4.89
9.4.88
9.4.87
9.4.86
9.4.85
9.4.84
9.4.83
9.4.82
9.4.81
9.4.80
9.4.79
9.4.78
9.4.77
9.4.76
9.4.75
9.4.74
9.4.73
9.4.72
9.4.71
9.4.70
9.4.69
9.4.68
9.4.67
9.4.66
9.4.65
9.4.64
9.4.63
9.4.62
9.4.61
9.4.60
9.4.59
9.4.58
9.4.57
9.4.56
9.4.55
9.4.54
9.4.53
9.4.52
9.4.51b
9.4.51
9.4.50
9.4.49
9.4.48
9.4.47
9.4.46
9.4.45
9.4.44
9.4.43
9.4.42
9.4.41
9.4.40
9.4.39
9.4.38
9.4.37
9.4.36
9.4.35
9.4.34
9.4.33
9.4.32
9.4.31
9.4.30
9.4.29
9.4.28
9.4.27
9.4.26
9.4.25
9.4.24
9.4.23
9.4.22
9.4.21
9.4.20
9.4.19
9.4.18
9.4.17
9.4.16
9.4.15
9.4.14
9.4.13
9.4.12
9.4.11
9.4.10
9.4.9
9.4.8
9.4.7
9.4.6
9.4.5
9.4.4
9.4.3
9.4.2
9.4.1
9.4.0
9.3.61
9.3.60
9.3.59
9.3.58
9.3.57
9.3.56
9.3.55
9.3.54
9.3.53
9.3.52
9.3.51
9.3.50
9.3.49
9.3.48
9.3.47
9.3.46
9.3.45
9.3.44
9.3.43
9.3.42
9.3.41
9.3.40
9.3.39
9.3.38
9.3.37
9.3.36
9.3.35
9.3.34
9.3.33
9.3.32
9.3.31
9.3.30
9.3.29
9.3.28
9.3.27
9.3.26
9.3.25
9.3.23
9.3.22
9.3.21
9.3.20
9.3.19
9.3.18
9.3.17
9.3.16
9.3.15
9.3.14
9.3.13
9.3.12
9.3.11
9.3.10
9.3.9
9.3.8
9.3.7
9.3.6
9.3.5
9.3.4
9.3.3
9.3.2
9.3.1
9.3.0b
9.2.25
9.2.24
9.2.23
9.2.22
9.2.21
9.2.20
9.2.19
9.2.18
9.2.17
9.2.16
9.2.15
9.2.14
9.2.13
9.2.12
9.2.11
9.2.10
9.2.9
9.2.8
9.2.7
9.2.6
9.2.5
9.2.4
9.2.3
9.2.2
9.2.1
9.2.0
9.1.91
9.1.90
9.1.89
9.1.88
9.1.87
9.1.86
9.1.85
9.1.84
9.1.83
9.1.82
9.1.81
9.1.80
9.1.79
9.1.78
9.1.77
9.1.76
9.1.75
9.1.72
9.1.71
9.1.70
9.1.69
9.1.68
9.1.67
9.1.66
9.1.65
9.1.64
9.1.63
9.1.62
9.1.61
9.1.60
9.1.59
9.1.58
9.1.57
9.1.56
9.1.55
9.1.54
9.1.53
9.1.52
9.1.51
9.1.50
9.1.36
9.1.35
9.1.34
9.1.33
9.1.32
9.1.31
9.1.30
9.1.29
9.1.28
9.1.27
9.1.26
9.1.25
9.1.24
9.1.23
9.1.22
9.1.21
9.1.20
9.1.19
9.1.18
9.1.17
9.1.16
9.1.15
9.1.13
9.1.12
9.1.11
9.1.10
9.1.9
9.1.8
9.1.7
9.1.6
9.1.5
9.1.4
9.1.3
9.1.2
9.1.0
9.0.68
9.0.67
9.0.66
9.0.65
9.0.64
9.0.63
9.0.62
9.0.61
9.0.60
9.0.59
9.0.58
9.0.57
9.0.56
9.0.55
9.0.54
9.0.53
9.0.52
9.0.51
9.0.50
9.0.48
9.0.47
9.0.46
9.0.45
9.0.44
9.0.43
9.0.42
9.0.41
9.0.40
9.0.39
9.0.38
9.0.37
9.0.36
9.0.35
9.0.34
9.0.33
9.0.32
9.0.31
9.0.30
9.0.29
9.0.28
9.0.27
9.0.26
9.0.25
9.0.24
9.0.22
9.0.21
9.0.20
9.0.19
9.0.18
9.0.17
9.0.16
9.0.15
9.0.14
9.0.13
9.0.12
9.0.11
9.0.10
9.0.9
9.0.8
9.0.7
9.0.6
9.0.5
9.0.4
9.0.3
9.0.2
9.0.1
9.0.0-e
9.0.0-d
9.0.0-c
9.0.0-b
9.0.0
8.0.3
8.0.2
8.0.1
8.0.0
v7.23.1987
v7.21.1979
v7.20.1975
7.19.1961
9.6.944
Labels
Clear labels   
ABS

Gestion des absences

  
à confirmer

   
API

API json

  
Apogée

Interfaces Apogée

  
bug

Something is not working

  
BUT

Bachelor IUT

  
Dev

Enhance code/refactoring/tools

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
Entreprises

App Relations Entreprises

  
frontend

HTML/CSS/JS

  
help wanted

Need some help

  
invalid

Something is wrong

  
Jury

Gestion des jurys

  
PE

Poursuites études

  
prio

prioritaire

  
question

More information is needed

  
RGPD

   
Users

Gestion utilisateurs

  
wontfix

This won't be fixed

No Label
ABS
à confirmer
API
Apogée
bug
BUT
Dev
duplicate
enhancement
Entreprises
frontend
help wanted
invalid
Jury
PE
prio
question
RGPD
Users
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ScoDoc/ScoDoc#470
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?